dragsort Issue Tracker Rss Feed

Reopened Issue: Dragged item bad positioned when using UI.Layout [24530]

mcm_ham — Fri, 14 Jun 2013 07:30:09 GMT

I use UI.Layout plugin to layout the page (top header, left menu, rest content). When I use the List DragSort for a list inside a UI.Layout content pane, the dragged item is bad positioned. It has an offset equal to the top left position of the UI.Layout pane. I'm testing with IE7, jquery 1.3.2, dragsort 0.3, ui.layout 1.2.0.

I have examined the plugin code, and I think the problem is caused because the list.draggedItem is positioned absolute inside a div already positioned absolute. The top, left css styles are not relative to the document, but to the parent absolute div. The offset() function is not 100% compatible with css({top:y,left:x}) when ancestor absolute divs are in play.

I have found a solution for me: substract the position of the absolute containers. My patch is adding this piece of code just before the last statement of the setPos function:

this.draggedItem.parents().each(function(){
if (this.style.position == "absolute") {
var offset = $(this).offset();
top -= offset.top;
left -= offset.left;
}
});

Reopened Issue: Only trigger dragEnd when order has changed [27382]

llorca — Fri, 14 Jun 2013 07:30:09 GMT

P:S. Is here a way to send request to server only when some items really reordered, not by click only on item ?

Reopened Issue: Small error in code [30203]

mcm_ham — Fri, 14 Jun 2013 07:30:09 GMT

In version 0.4.1, Line 188 reads:

list.removeAttr("data-origStyle"); (causing an error).

But should be

list.draggedItem.removeAttr("data-origStyle");

Reopened Issue: dragEnd callback doesn't always fire when it should [31969]

mcm_ham — Fri, 14 Jun 2013 07:30:08 GMT

The example html page provided with your code doesn't provide for a situation where this can occur but there is a fundamental flaw in the code: The dragEnd callback only fires when the item being dragged has it's order changed (either within it's own list, or within the new list that it is being dragged to).

The documentation says: "dragEnd: The callback function that will be called after the dragging has ended."

Unforunately this is not true. If you want to see a situation where it doesn't work that way, setup a page where there are is a master list containing a couple draggable item's in it, and then a couple of other empty lists that can be dragged to/from, but which don't have any items in them to begin with. Setup the dragEnd callback to show an alert so that you know when it's being fired. Drag one of the items from the master list to one of the empty lists, notice the callback fires. Now drag that same item from the new list that it's a child of, to another one of the empty lists. Notice the callback doesn't fire, even though the item was moved!

The bug occurs because the dropEnd callback is only set to fire when one or more of the items has it's order changed within a list. The callback should always fire if an item is dragged from one destination to another, regardless of whether the order changes. Otherwise, if you only have a few items and a bunch of possible destinations, the dropEnd callback won't get fired when expected (if at all).

I patched the code so that it functions in the way I desired and I have attached the patch here. Thanks for the script, let me know if anyone has any questions.

Created Unassigned: Draggable item with scrollbar inside [34156]

iuzzef — Sun, 09 Jun 2013 16:45:26 GMT

Hi, I have a dashboard widget that is draggable nicely with List DragSort, however inside that <LI> the widget body (a div) have a specific size and a sometimes a scrollbar (overflow:auto).

The scrollbar doesn't work on Firefox, and on IE creates a sticky effect very unpleasant.

For what I see there are options for scrolling outside the draggable item but not inside...

Does nobody have fund this issue? any way to work around this?

Thanks

Closed Issue: Dragged item bad positioned when using UI.Layout [24530]

mcm_ham — Thu, 16 May 2013 11:29:23 GMT

Closed Issue: Only trigger dragEnd when order has changed [27382]

llorca — Thu, 16 May 2013 11:29:23 GMT

P:S. Is here a way to send request to server only when some items really reordered, not by click only on item ?

Closed Issue: Small error in code [30203]

mcm_ham — Thu, 16 May 2013 11:29:23 GMT

In version 0.4.1, Line 188 reads:

list.removeAttr("data-origStyle"); (causing an error).

But should be

list.draggedItem.removeAttr("data-origStyle");

Closed Issue: dragEnd callback doesn't always fire when it should [31969]

mcm_ham — Thu, 16 May 2013 11:29:22 GMT

Created Issue: Allowing a header block... [33956]

drbaggy — Wed, 10 Apr 2013 20:41:09 GMT

The table code currently doesn't allow a <thead> block at the top of the sortable rows - you can fix this with the following code at line 22:

if( $(cont).is("table") && $(cont).children('tbody').size() === 1 )
cont = $(cont).children('tbody').get(0);

Created Issue: Error in ie 8 [33848]

pablodif — Thu, 07 Mar 2013 11:58:11 GMT

it doesn't work in ie 8. i test it in other browser and it work fine for me. There is a way to solve it ?

Thanks !
regards.

Created Issue: Dropping in container element does not work [33749]

DanSwitzer2 — Fri, 08 Feb 2013 20:01:57 GMT

I have 2 lists w/a fixed height. I noticed when you drag from list 1 to 2 and release the mouse button when over list 2, but you are not over list item, then the move does not take. Unless you have moused over an <li> item from list 2, the drop does not work the way you'd expect.

To fix the problem, I added a patch to the source code that checks when dragging between lists and if you're dropping to a list and the list.placeHolderItem object isn't in the current list, it'll move the item to the dropped list container.

This allows you to have a fixed height on your <ul> elements and drop the elements. This should also resolve issues where an "empty" element can be hard to drop to. This should also fix issues where there is margin/whitespace between the <li> items.

I'm attaching my patch.

Created Issue: Broken layout with dimensions in percentages [33636]

brankovukelic — Wed, 02 Jan 2013 21:33:24 GMT

I have an UL with 9 LI items laid out more or less like the image on the project's homepage. The difference is that UL has width and height set to 100% within a fixed-dimension container, and all LI items have width and height set to 33.33% and floated left.

What happens is that layout becomes broken in various ways when placeholder replaces one of the LI elements. I managed to fix this by removing the `.css(...)` part on line 124 (I am using the version of the code that can be downloaded from the download section).

I assume that the calculated width/height that jQuery returns doesn't exactly match the way browser calculates 33.33% in this case.

Here is the relevant CSS I use:

.shuffleboard {
position: relative;
padding: 1em;
}

.shuffleboard ul {
position: relative;
margin: 0 auto;
padding: 0;
width: 100%;
height: 100%;
}

.shuffleboard li {
list-style: none;
float: left;
width: 33.333%;
height: 33.333%;
position: relative;
}

Commented Issue: No data-listidx attribute on list items when using multiple lists [33582]

LuisRodrigues — Tue, 18 Dec 2012 19:17:30 GMT

When using more than one list in the selector, with or without dragBetween set to true, data-listidx will be assigned to the UL elements used in the selector and not the child LI elements, leaving no way of saving the list order.
Comments: ** Comment from web user: LuisRodrigues **

This is an example of the bug

Created Issue: No data-listidx attribute on list items when using multiple lists [33582]

LuisRodrigues — Tue, 18 Dec 2012 19:08:42 GMT

Commented Issue: Only trigger dragEnd when order has changed [27382]

llorca — Fri, 14 Dec 2012 06:44:25 GMT

<p>P:S. Is here a way to send request to server only when some items really reordered, not by click only on item ?</p>

Comments: ** Comment from web user: llorca **

Hi how can I dragsort stop and start? Or disable and enable?
In other function.

Because I want to use with together Uploadify.

Photo instantly uploading I want to stop or disable dragsort.
Thank you.

Commented Issue: dragsort won't initialize if all lists are empty [33484]

himdel — Tue, 27 Nov 2012 21:18:43 GMT

I have 3 lists, initially empty, filled dynamically later.
If I call $(list).dragsort({ dragSelector: '.item' }) when they are empty, nothing happens.
However, if at least one of the is nonempty, all of them get initialized.

This is clearly a bug, either it should initialize either way (preferred) or only for nonempty lists.
Happens in current firefox & chrome, not tested elsewhere.

For the, the workaround of creating the lists with a placeholder item, initializing and then deleting the item works.
Comments: ** Comment from web user: himdel **

Additional info:

I can actually make it intialize almost fine using
$('.orderselect').dragsort({ itemSelector: '.option', dragSelector: '.option', placeHolderTemplate: '<div></div>' })

But then, dropping doesn't work - the item returns where it was.

If I add
$('.orderselect').dragsort({ itemSelector: '.option', dragSelector: '.option', placeHolderTemplate: '<div class="option"></div>' })
it works, but weird - an empty option appears while dragging, which I don't want.

Created Issue: dragsort won't initialize if all lists are empty [33484]

himdel — Tue, 27 Nov 2012 21:10:41 GMT

Created Issue: scrollContainer loses correct item offsets when dragging [33163]

zachrybaker — Mon, 24 Sep 2012 21:59:38 GMT

Hi, I believe that I have found a problem with the scrolling code.

For example, use this url on my development box: http://slideshowmaker.ath.cx/index.htm :

If you drag one of the first few slides past the area so that the slider pane scrolls, then you grab one of the last items and try to move it left, you will see that the "selected" item gets drawn many pixels left of where the mouse really is. It seems to lose track of the correct offset because its not taking into account the scrollContainer's scolled position.

I figured the scrollContainer's selector should be '.slides-wrapper .slider-pane' if I understood the docs but seems '.slider-pane .slider-timeline' works better (actually will scroll).

Or am I missing something?

Thanks

Created Issue: Add Tolerance to trigger to avoid missing click [32717]

davidcl64 — Tue, 15 May 2012 15:56:55 GMT

Similar to patch: 12014 - *BUT* with some additional changes (see attached diff) and without allowing configuration of tolerance (I prefer allowing configuration)

I don't know if this fixes all of the issues with the above mentioned patch, but simply adding tolerance will cause some behavior problems.

This diff also tracks:
1. currentTarget - the target over which the drag started. This avoids the drift problem introduced by adding tolerance due to the current code relying on '$(e.target).closest'.

2. startX & startY - stores and calculates the distance the mouse has moved and only triggers drag start when the tolerance has been exceeded.

3. dragStart - modified to use currentTarget rather than closest target to avoid the drift issue.

I don't know if this diff fixes all remaining issues, but these were the ones I had encountered during my testing.